Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing specifications sections #35704

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Add missing specifications sections #35704

merged 2 commits into from
Sep 2, 2024

Conversation

GaurangTandon
Copy link
Contributor

The live specifications are here: https://w3c.github.io/selection-api/#dom-selection-modify

I am not sure if my change works or not though. I could not find documentation for the {{Specifications}} tag. I noticed that other documentation pages (like the one for Selection.toString()) uses them and it works fine, so I just copied from there. Please let me know if there's another way to achieve this correctly. Thanks!

@GaurangTandon GaurangTandon requested a review from a team as a code owner September 2, 2024 12:51
@GaurangTandon GaurangTandon requested review from wbamberg and removed request for a team September 2, 2024 12:51
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited
Loading

Preview URLs (107 pages)
Flaws (7)

Note! 102 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/SVGAnimatedPreserveAspectRatio
Title: SVGAnimatedPreserveAspectRatio
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGAnimatedPreserveAspectRatio/baseVal does not exist
    • /en-US/docs/Web/API/SVGAnimatedPreserveAspectRatio/animVal does not exist

URL: /en-US/docs/Web/API/SVGAnimatedNumberList
Title: SVGAnimatedNumberList
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGAnimatedNumberList/baseVal does not exist
    • /en-US/docs/Web/API/SVGAnimatedNumberList/animVal does not exist

URL: /en-US/docs/Web/API/SourceBuffer/changeType
Title: SourceBuffer: changeType() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaSource/sourceopen_event does not exist

URL: /en-US/docs/Web/API/MediaTrackSupportedConstraints
Title: MediaTrackSupportedConstraints
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaTrackSupportedConstraints/resizeMode does not exist

URL: /en-US/docs/Web/HTML/Element/dir
Title: <dir>: The Directory element
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLDirectoryElement does not exist

(comment last updated: 2024-09-02 19:28:38)

@GaurangTandon
Copy link
Contributor Author

Based on the preview it looks like my approach was correct 😄

@Josh-Cena
Copy link
Member

I've discovered a lot more specification links that are not displayed on pages. Do you mind if I add them to this PR?

@GaurangTandon
Copy link
Contributor Author

Sure please go ahead 🙂

@Josh-Cena Josh-Cena requested review from a team as code owners September 2, 2024 19:27
@Josh-Cena Josh-Cena requested review from chrisdavidmills and removed request for a team September 2, 2024 19:27
@Josh-Cena Josh-Cena changed the title Link specifications for Selection.modify method Add missing specifications sections Sep 2, 2024
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs size/m [PR only] 51-500 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Sep 2, 2024
Josh-Cena
Josh-Cena approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Great catch on this!

@Josh-Cena Josh-Cena merged commit b25d877 into mdn:main Sep 2, 2024
8 checks passed
@GaurangTandon
Copy link
Contributor Author

No worries, thanks for the huge update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaurangTandon @Josh-Cena