Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental features for Fx 122: shadowrootmode, async clipboard #31612

Merged
merged 11 commits into from
Jan 15, 2024

Conversation

pepelsbey
Copy link
Member

Description

  1. Adds a section to the Experimental features page
  2. Adds behind-the-flag features for the Fx 122 release notes

Motivation

To support Firefox 122 release.

Related issues and pull requests

@pepelsbey pepelsbey requested a review from a team as a code owner January 9, 2024 12:08
@pepelsbey pepelsbey requested review from hamishwillee and removed request for a team January 9, 2024 12:08
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Preview URLs

External URLs (5)

URL: /en-US/docs/Mozilla/Firefox/Releases/122
Title: Firefox 122 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-01-15 12:30:23)

@bsmth bsmth added this to the FF122: Jan 23rd milestone Jan 12, 2024
@bsmth
Copy link
Member

bsmth commented Jan 12, 2024

After 24aa0ba, you may have to escape the newlines in your list like so:

- **Popover API** - `dom.element.popover.enabled`\
  \
  Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API, including styling with the CSS [`:popover-open`](/en-US/docs/Web/CSS/:popover-open) pseudo-class and extended support for the [`::backdrop`](/en-US/docs/Web/CSS/::backdrop) pseudo-element. See the [Popover API](/en-US/docs/Web/API/Popover_API) reference for more details. ([Firefox bug 1823757](https://bugzil.la/1823757))

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left two really minor suggestions open for adding "the" where I think it might help. Another formatting hint if you want to use normal <ul>s instead of <dl>s.

Otherwise, looking good! Leaving my +1 🎉

pepelsbey and others added 3 commits January 12, 2024 17:20
Co-authored-by: Brian Thomas Smith <[email protected]>
…t into experimental-fx-122

* 'experimental-fx-122' of github.com:pepelsbey/mdn-content:
  Apply suggestions from code review
@pepelsbey
Copy link
Member Author

pepelsbey commented Jan 12, 2024

You may have to escape the newlines in your list

I added a period instead. I don’t like two <br>s this escaping adds. I hope it’s all right this way :)

Also, I added another experimental feature for you to review (Intl.Segmenter). Sorry!

@pepelsbey pepelsbey requested a review from bsmth January 12, 2024 16:30
@bsmth
Copy link
Member

bsmth commented Jan 15, 2024

I added a period instead. I don’t like two <br>s this escaping adds. I hope it’s all right this way :)

Gotcha I wasn't sure if you wanted an empty line inside the list, as with GFM, you can do:

* List Item

  Thing in the list

And it preserves the indentation:

  • List Item

    Thing in the list

In Yari, the whitespace is stripped, apparently, so you have to add \ backslashes to force this style:

Screenshot:

image

On the formatting topic, what do you think about bolding the feature per list item like:

* __Topic__ `pref?`: Description
* __Popover API__ (`dom.element.popover.enabled`): Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API...
* __Popover API__ - `dom.element.popover.enabled`: Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API...
  • Popover API (dom.element.popover.enabled): Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API...
  • Popover API - dom.element.popover.enabled: Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API...

Also, I added another experimental feature for you to review (Intl.Segmenter). Sorry!

No problem, I will check it out :)

@pepelsbey pepelsbey merged commit c3d3891 into mdn:main Jan 15, 2024
7 checks passed
@pepelsbey pepelsbey deleted the experimental-fx-122 branch January 15, 2024 12:30
@pepelsbey
Copy link
Member Author

what do you think about bolding the feature per list item like

Good point! Applied it, thanks.

dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
…mdn#31612)

* Add experimental features for Fx 122

* Apply suggestions from code review

Co-authored-by: Brian Thomas Smith <[email protected]>

* Use simpler list

* Apply suggestions from code review

Co-authored-by: Brian Thomas Smith <[email protected]>

* Add Intl.Segmenter

* Apply suggestions from code review

Co-authored-by: Brian Thomas Smith <[email protected]>

* Bold the titles

---------

Co-authored-by: Brian Thomas Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants