-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental features for Fx 122: shadowrootmode, async clipboard #31612
Conversation
Preview URLs External URLs (5)URL:
URL:
(comment last updated: 2024-01-15 12:30:23) |
Co-authored-by: Brian Thomas Smith <[email protected]>
After 24aa0ba, you may have to escape the newlines in your list like so: - **Popover API** - `dom.element.popover.enabled`\
\
Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API, including styling with the CSS [`:popover-open`](/en-US/docs/Web/CSS/:popover-open) pseudo-class and extended support for the [`::backdrop`](/en-US/docs/Web/CSS/::backdrop) pseudo-element. See the [Popover API](/en-US/docs/Web/API/Popover_API) reference for more details. ([Firefox bug 1823757](https://bugzil.la/1823757)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left two really minor suggestions open for adding "the" where I think it might help. Another formatting hint if you want to use normal <ul>
s instead of <dl>
s.
Otherwise, looking good! Leaving my +1 🎉
Co-authored-by: Brian Thomas Smith <[email protected]>
…t into experimental-fx-122 * 'experimental-fx-122' of github.com:pepelsbey/mdn-content: Apply suggestions from code review
I added a period instead. I don’t like two Also, I added another experimental feature for you to review (Intl.Segmenter). Sorry! |
Gotcha I wasn't sure if you wanted an empty line inside the list, as with GFM, you can do: * List Item
Thing in the list And it preserves the indentation:
In Yari, the whitespace is stripped, apparently, so you have to add On the formatting topic, what do you think about bolding the feature per list item like: * __Topic__ `pref?`: Description
* __Popover API__ (`dom.element.popover.enabled`): Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API...
* __Popover API__ - `dom.element.popover.enabled`: Displaying popovers on top of page content is now supported via HTML attributes or JavaScript API...
No problem, I will check it out :) |
Co-authored-by: Brian Thomas Smith <[email protected]>
Good point! Applied it, thanks. |
…mdn#31612) * Add experimental features for Fx 122 * Apply suggestions from code review Co-authored-by: Brian Thomas Smith <[email protected]> * Use simpler list * Apply suggestions from code review Co-authored-by: Brian Thomas Smith <[email protected]> * Add Intl.Segmenter * Apply suggestions from code review Co-authored-by: Brian Thomas Smith <[email protected]> * Bold the titles --------- Co-authored-by: Brian Thomas Smith <[email protected]>
Description
Motivation
To support Firefox 122 release.
Related issues and pull requests