Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs for the Navigation API #21960
add docs for the Navigation API #21960
Changes from 1 commit
f74c58c
91e37e2
388f304
a9ca266
0c7dd0d
03a56c7
6b7a904
9a2b3ba
fad99a3
fc0e240
c8aeb47
c0ed753
44c0b18
72f8ce2
b2e1e36
4554e97
d264c4f
1e96c03
0e18d96
de7f600
43f9c1f
f3e94db
5a47f9e
b4a42f3
40f93b0
dc435da
12a51d2
33a7e8e
5938b37
ecee4c7
6333b97
8725f8e
03efe1e
fa2f482
3bb1bed
251848f
b16a267
127c770
3761a1d
991c81a
e816cb1
9696dbc
504f04f
ed352c5
b0a10a5
5e6be2a
4ad513f
af10131
3b887e3
9c9e8da
d1b7e04
6448d5b
f4b5752
7f81b8b
1476651
1805606
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that canceling traversals is not yet implemented anywhere, although we've updated the explainer and spec since we have an implementation in progress. I'm not sure whether that's necessary to mention here, or elsewhere, or not at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to
We can always update it when the implementation lands. Let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, it's a bit more subtle than that. Canceling (most) push/reload/replace navigations is possible today. It's the traverse navigations which are still a future feature.
You can see the diff, which represents what's not possible yet but will be soon, in WICG/navigation-api@a430943
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I see. I've updated it again, to
I'll keep it simple for now here, and then link to your explainer text when it is published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be listed in alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of did, but decided to put the event objects at the end in a separate alphabetical list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a minor point, but I do think consistent alpha order is the best option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, updated in next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's only one spec so it's unfortunate that we have two spec entries here. I guess that's because we have 2 BCD queries. We are in a bit of a mess wrt BCD and spec URLs, especially regarding API overview pages. But maybe it would be better to use a spec-url front matter key? Although tbh I'm not sure if that will work to override the BCD ones, or if you will just end up with three of them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what you mean by "spec-url front matter key".
I could just include a single browser compact entry, as it would still provide an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can include an item in the front matter YAML for the page like:
content/files/en-us/web/css/display-inside/index.md
Line 12 in 7379064
...I think that will then be used for the specifications section instead of BCD (?). I hope so anyway.
If the
spec-urls
thing works as expected it would be better, because the BCD entry will presumably link to a fragment inside the spec, while in an overview page we really want to just link to the spec AFAICT.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it, and the result is that we end up with three spec URLs listed rather than two. I could see this totally making sense if the
spec-urls
override the URLs taken from thebrowser-compat
entries, but it is additive.I'll leave my content as-is, for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I wish this stuff worked better.