Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror Chrome Android data for Edit Context API #22779

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Apr 6, 2024

https://chromestatus.com/feature/5041440373604352 says this is supported
in Chrome for Android, and wpt.fyi results agree:
https://wpt.fyi/results/editing/edit-context?label=master&product=chrome&product=chrome_android

This updates all features tagged with web-features:edit-context,
originally added here:
#21603

https://chromestatus.com/feature/5041440373604352 says this is supported
in Chrome for Android, and wpt.fyi results agree:
https://wpt.fyi/results/editing/edit-context?label=master&product=chrome&product=chrome_android

This updates all features tagged with web-features:edit-context,
originally added here:
mdn#21603
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 6, 2024
@foolip foolip requested a review from Elchi3 April 6, 2024 08:26
@foolip
Copy link
Contributor Author

foolip commented Apr 6, 2024

@Elchi3 I suspect there is an underlying issue with the process for beta release updates. I guess that the collector is only running desktop, so the support for Chrome Android is actually unknown based on the data? Are there other PRs like #21603 that I should go back and double check?

@Elchi3
Copy link
Member

Elchi3 commented Apr 6, 2024

Thanks for the feedback, @foolip! We do run the collector on mobile browsers. I see that the collector is proposing to update this, but we haven't had the time to make a PR against BCD yet.

When creating PRs like #21603, new feature additions default to mirror for mobile browsers if no other information is available. https://github.com/openwebdocs/mdn-bcd-collector/blob/07a13c540082e4ae1a05962e90d93779e589ef54/scripts/add-new-bcd.ts#L36. I think I might have updated this to false manually at the time. Future PRs for Chrome 122, 123 or 124 beta look OK to me.

openwebdocs/mdn-bcd-collector#951 might help to have data available at the time it is needed.

@foolip
Copy link
Contributor Author

foolip commented Apr 6, 2024

Thanks for checking the other beta PRs, @Elchi3! If this was most likely manually updated, then no process fixes are needed, which is good! Also good that the collector does agree with these changes :)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @foolip 👍

@Elchi3 Elchi3 merged commit 146a093 into mdn:main Apr 8, 2024
5 checks passed
@foolip foolip deleted the android-edit-context branch April 8, 2024 12:12
@foolip foolip restored the android-edit-context branch April 8, 2024 12:12
@foolip foolip deleted the android-edit-context branch April 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants