Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadowrootmode in Firefox preview #21815

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Add shadowrootmode in Firefox preview #21815

merged 2 commits into from
Jan 2, 2024

Conversation

pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented Jan 2, 2024 •
edited
Loading

Summary

Declarative Shadow DOM support via the shadowrootmode attribute for the <template> element will be shipped in Firefox 122 behind the flag, disabled by default for now.

Test results and supporting details

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Jan 2, 2024
@pepelsbey pepelsbey mentioned this pull request Jan 2, 2024
Closed
10 tasks
Elchi3
Elchi3 reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be enabled in Firefox 122.

Can you please provide a source for this information?

Currently it appears to be behind the "dom.webcomponents.shadowdom.declarative.enabled" preference: https://searchfox.org/mozilla-central/source/dom/webidl/HTMLTemplateElement.webidl#17

@pepelsbey
Copy link
Member Author

Can you please provide a source for this information?

In the Bugzilla:

Status: NEW → RESOLVED
status-firefox122: --- → fixed
Target Milestone: --- → 122 Branch

This task is part of the Firefox 122 release project.

Currently it appears to be behind the […] preference

It’s behind the preference, but it will be set to true by default.

@evilpie
Copy link
Contributor

evilpie commented Jan 2, 2024

@Elchi3 is correct. This feature is Nightly only, per this pref: https://searchfox.org/mozilla-central/rev/9137f80064364a41a1de394af4ce05dffdbf68e6/modules/libpref/init/StaticPrefList.yaml#4551. See also Bug 1870052 -
Enable Declarative ShadowDOM on early beta

@pepelsbey
Copy link
Member Author

Sorry, I guess I got it wrong. I’ll change it to preview then.

@pepelsbey pepelsbey changed the title Add shadowrootmode in Firefox 122 Add shadowrootmode in Firefox preview Jan 2, 2024
@pepelsbey pepelsbey requested a review from Elchi3 January 2, 2024 15:45
Elchi3
Elchi3 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit 62ac4d2 into mdn:main Jan 2, 2024
6 checks passed
@pepelsbey pepelsbey deleted the shadowrootmode-firefox branch January 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepelsbey @evilpie @Elchi3