fix: clippy warnings

mavlink · Aug 25, 2024 · 552560b · 552560b
1 parent 51e6de1
commit 552560b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/mavlink-core/src/connection/direct_serial.rs b/mavlink-core/src/connection/direct_serial.rs
@@ -124,6 +124,6 @@ impl<M: Message> MavConnection<M> for SerialConnection {
 
     #[cfg(feature = "signing")]
     fn setup_signing(&mut self, signing_data: Option<SigningConfig>) {
-        self.signing_data = signing_data.map(|cfg| SigningData::from_config(cfg))
+        self.signing_data = signing_data.map(SigningData::from_config)
     }
 }
diff --git a/mavlink-core/src/connection/file.rs b/mavlink-core/src/connection/file.rs
@@ -75,6 +75,6 @@ impl<M: Message> MavConnection<M> for FileConnection {
 
     #[cfg(feature = "signing")]
     fn setup_signing(&mut self, signing_data: Option<SigningConfig>) {
-        self.signing_data = signing_data.map(|cfg| SigningData::from_config(cfg))
+        self.signing_data = signing_data.map(SigningData::from_config)
     }
 }
diff --git a/mavlink-core/src/connection/tcp.rs b/mavlink-core/src/connection/tcp.rs
@@ -144,6 +144,6 @@ impl<M: Message> MavConnection<M> for TcpConnection {
 
     #[cfg(feature = "signing")]
     fn setup_signing(&mut self, signing_data: Option<SigningConfig>) {
-        self.signing_data = signing_data.map(|cfg| SigningData::from_config(cfg))
+        self.signing_data = signing_data.map(SigningData::from_config)
     }
 }
diff --git a/mavlink-core/src/connection/udp.rs b/mavlink-core/src/connection/udp.rs
@@ -196,7 +196,7 @@ impl<M: Message> MavConnection<M> for UdpConnection {
 
     #[cfg(feature = "signing")]
     fn setup_signing(&mut self, signing_data: Option<SigningConfig>) {
-        self.signing_data = signing_data.map(|cfg| SigningData::from_config(cfg))
+        self.signing_data = signing_data.map(SigningData::from_config)
     }
 }
 

diff --git a/mavlink-core/src/lib.rs b/mavlink-core/src/lib.rs
@@ -705,11 +705,11 @@ impl MAVLinkV2MessageRaw {
     pub fn calculate_signature(&self, secret_key: &[u8], target_buffer: &mut [u8; 6]) {
         let mut hasher = Sha256::new();
         hasher.update(secret_key);
-        hasher.update(&[MAV_STX_V2]);
+        hasher.update([MAV_STX_V2]);
         hasher.update(self.header());
         hasher.update(self.payload());
         hasher.update(self.checksum_bytes());
-        hasher.update(&[self.signature_link_id()]);
+        hasher.update([self.signature_link_id()]);
         hasher.update(self.signature_timestamp_bytes());
         target_buffer.copy_from_slice(&hasher.finalize()[0..6]);
     }
@@ -917,9 +917,9 @@ async fn read_v2_raw_message_async_inner<M: Message, R: tokio::io::AsyncReadExt
             }
         }
 
-            return Ok(message);
-        }
+        return Ok(message);
     }
+}
 
 /// Async read a raw buffer with the mavlink message with signing support
 /// V2 maximum size is 280 bytes: `<https://mavlink.io/en/guide/serialization.html>`