Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom gimbal control #7627

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Custom gimbal control #7627

merged 1 commit into from
Jul 28, 2019

Conversation

dogmaphobic
Copy link
Contributor

Showing how to implement a custom gimbal control (re-using the virtual joystick control)
Also adding a setting so the user can enable/disable the control.

Screen Shot 2019-07-27 at 5 16 21 PM

@dogmaphobic dogmaphobic merged commit 3ee40d0 into master Jul 28, 2019
@dogmaphobic dogmaphobic deleted the customGimbalControl branch July 28, 2019 01:40
@hamishwillee
Copy link
Contributor

@dogmaphobic Pretty cool.

  1. How do I enable this if I want it on my customer version
  2. How do you expect people discover this example? (and similarly the navigation item you created)?

Perhaps a page in the dev guide? https://dev.qgroundcontrol.com/en/

@dogmaphobic
Copy link
Contributor Author

  1. How do I enable this if I want it on my customer version

Just rename "custom-example" to "custom" before loading the project in Qt Creator. If you had a build already, you will need to delete the build directory (run qmake again). If you do this all the time, it's simpler to just create a symlink (ln -s custom-example custom).

2. How do you expect people discover this example? (and similarly the navigation item you created)?

Good question. Not sure what the best way to document it.

Yasen did a cool PR today updating the entire color palette for the custom build to show how it's done: #7633

@hamishwillee
Copy link
Contributor

hamishwillee commented Jul 29, 2019

Not sure what the best way to document it.

I am. See mavlink/qgc-dev-guide#70

In theory could "seed" this in a week or so. But I don't know enough about what makes a custom control and how it gets hooked into the system - ie what does someone else need to know to extend this vs fully replace it vs just learn how to create an arbitrary control.

Further, this is a modified joystick control. Does it play nice if someone adds a joystick?

PS (Edited). I have a tendency to want to document "end to end" and everything for all people. But that might not be necessary for the level of users you're targeting. The minimal here is that they should know this exists and how to enable it. For gimbal then the question of "right level so that people can learn from it" really depends on what you think is best.

@zeev-mindali
Copy link

Showing how to implement a custom gimbal control (re-using the virtual joystick control) Also adding a setting so the user can enable/disable the control.

Screen Shot 2019-07-27 at 5 16 21 PM

Dear Friend,

how i can get this plugin???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants