Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Vehicle Panel Overhaul #11970

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

demirciAhmet
Copy link

@demirciAhmet demirciAhmet commented Oct 6, 2024

Description

Related to #11693

Here are the changes by the panel overhaul:

  • New solid top-right panel implemented, changed overall design of the multi vehicle list.
  • To be able to add guided action confirmation to the buttons of the multi-vehicle panel, a new logic "Select vehicles - Perform action" implemented (now you first select vehicles from the panel by tapping on them, then perform the action to the selected vehicles, otherwise you had to confirm one by one for the each action, which would be very annoying).
  • Guided action confirmation for the mv actions
  • New swipe pages embedded in the new top-right panel. This way, other components such as the PhotoVideoControl, or any other widgets that may be implemented later, can be added to the top-right panel.

image

untitled.1.mp4

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DonLakeFlyer
Copy link
Contributor

Is there a fixed amount of space you devote to vehicle indicators which scrolling? is this why the list is clipped at the bottom?

@demirciAhmet
Copy link
Author

Is there a fixed amount of space you devote to vehicle indicators which scrolling? is this why the list is clipped at the bottom?

Yes, it has a fixed height (currently half of the panel height), you scroll through the panel if there are many vehicles. This way there is no need to worry about adding new widgets to the panel in the future.

I thought about separating the lower part of the panel for buttons, and other widgets, which will be stacked page by page.

@demirciAhmet demirciAhmet marked this pull request as ready for review October 29, 2024 18:20
@demirciAhmet demirciAhmet changed the title [Draft] Multi Vehicle Panel Overhaul Multi Vehicle Panel Overhaul Oct 29, 2024
@HTRamsey HTRamsey requested a review from DonLakeFlyer October 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants