Block access to contact information updated

[shinde-rahul]

Q	A
Bug fix? (use the a.b branch)	🟢
New feature/enhancement? (use the a.x branch)	🔴
Deprecations?	🔴
BC breaks? (use the c.x branch)	🔴
Automated tests included?	🟢
Related user documentation PR URL	mautic/user-documentation#...
Related developer documentation PR URL	mautic/developer-documentation-new#...
Issue(s) addressed	Fixes #...

Description

This PR fixes the handling of unexpected exceptions and the access to contact information without the necessary permissions.

Before	After

---

📋 Steps to test this PR:

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Remove all contact permissions (email:emails:viewown, email:emails:viewother)
3. Navigate to a segment details view, click on contacts
4. The contacts included in the segment are visible

The contact grid is permission is updated for Campaign and Email details page, out of which Email pages has the issue as mentioned in the description so updated testing steps are,

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Create a non-admin user with the following permission
   1. Email: View Own, View Others, Create
   2. Contacts: View Own, View Others, Create
3. Create contacts with different owners and create segments for these contact
4. Create a broadcast or segment-type email and select the above-created segment.
5. Run the broadcast
6. Navigate to the email details page and click on the Contact tab
7. The contact grid will start showing up

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.42%. Comparing base (43df2ae) to head (18f942d).
Report is 14 commits behind head on 5.2.

Additional details and impacted files

@@            Coverage Diff            @@
##                5.2   #14315   +/-   ##
=========================================
  Coverage     63.41%   63.42%           
  Complexity    34627    34627           
=========================================
  Files          2273     2273           
  Lines        103591   103595    +4     
=========================================
+ Hits          65691    65703   +12     
+ Misses        37900    37892    -8     

Files with missing lines	Coverage Δ
...s/CampaignBundle/Controller/CampaignController.php	69.33% <100.00%> (+1.36%)	⬆️
...bundles/EmailBundle/Controller/EmailController.php	64.36% <100.00%> (ø)
...dles/LeadBundle/Controller/EntityContactsTrait.php	79.16% <100.00%> (+5.83%)	⬆️

[andersonjeccel]

@shinde-rahul

Created a role and a user assigned to the role

You said to remove email permissions, removed
Also removed most related to contacts

Saved

logged in the user

Still able to see contacts within a segment

I'm sure to have your branch checked locally

Do I need to do something additional for it to take effect?

[shinde-rahul]

@andersonjeccel I have updated the description with updated testing steps,

The contact grid is permission is updated for Campaign and Email details page, out of which Email pages have the issue as mentioned in the description, so updated testing steps are,

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Create a non-admin user with the following permission
3. Email: View Own, View Others, Create
4. Contacts: View Own, View Others, Create
5. Create contacts with different owners and create segments for these contact
6. Create a broadcast or segment-type email and select the above-created segment.
7. Run the broadcast
8. Navigate to the email details page and click on the Contact tab
9. The contact grid will start showing up

[JonasLudwig1998]

Works from an user perspective, great job

[matbcvo]

@shinde-rahul please rebase your PR onto the 5.2 branch.

[shinde-rahul]

Changed the base branch to 5.2.