Skip attachments with missing thumbnails #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge yet. Working on making this nicer. |
|
@d235j, any progress here? |
|
@ryanpcmcquen I ended up taking a different approach since the size of my Signal database was crashing the browser. I wrote a separate script that converts the extracted jsons to text logs, with attachments referenced. Unfortunately it seems that Signal has recently changed the database schema, which means the old contacts.csv no longer contains what it used to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that some attachments might be missing thumbnails. This is not a great fix but it works for now.
It might fix #5.