Support touch events for pre-iOS13 devices #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slider didn't work on my iPad Mini 2 (iOS 12). Another user had the same issue so I've put a PR together for both of us.
The issue is that PointerEvent is only available in Safari/Webkit from iOS13+ (per https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/pointerdown_event#browser_compatibility), so this PR introduces a fallback to TouchEvent.
If you prefer not to support < iOS12, just discard this and I'll use my fork. I haven't actually tested that every action works properly on these legacy devices, because I'm only using the slider for my personal apps.
Many thanks for the great card.