Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix postgres schema after dropping old tables #16730

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Conversation

DMRobertson
Copy link
Contributor

This resolves a conflict between
#16658 and #16652
and should unsad CI.

David Robertson added 2 commits December 5, 2023 10:29
This resolves a conflict between
#16658 and
#16652
and should unsad CI.
@Half-Shot
Copy link
Collaborator

Aha, this is why #16729 is failing. Thanks!

@DMRobertson DMRobertson marked this pull request as ready for review December 5, 2023 10:50
@DMRobertson DMRobertson requested a review from a team as a code owner December 5, 2023 10:50
@DMRobertson
Copy link
Contributor Author

The migrations I deleted should correspond exactly to the tables in this delta:

-- Drop the old event transaction ID table, the event_txn_id_device_id table
-- should be used instead.
DROP TABLE IF EXISTS event_txn_id;
-- Drop tables related to MSC2716 since the implementation is being removed
DROP TABLE IF EXISTS insertion_events;
DROP TABLE IF EXISTS insertion_event_edges;
DROP TABLE IF EXISTS insertion_event_extremities;
DROP TABLE IF EXISTS batch_events;

@DMRobertson DMRobertson merged commit 0bb8e41 into develop Dec 5, 2023
41 checks passed
@DMRobertson DMRobertson deleted the dmr/fix-postgres branch December 5, 2023 11:08
@DMRobertson DMRobertson changed the title Fix postgres schema after batch_events dropped Fix postgres schema after dropping old tables Dec 5, 2023
DMRobertson pushed a commit that referenced this pull request Dec 5, 2023
This reverts two commits:

    0bb8e41
    "Fix postgres schema after dropping old tables (#16730)"

and

    51e4e35
    "Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit one. This should allow use of Postgres logical replication. (take  2, now with no added deadlocks!) (#16658)"

and also amends the changelog.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants