Downgrade repl stream time out error to warning (#16401)

This is because if a worker reaches ~100% CPU then everything starts lagging and we hit the log line a lot. When at error we invoke sentry and that has a lot of overhead, which then puts even more pressure on the worker.
matrix-org · Sep 29, 2023 · 20fb08e · 20fb08e
1 parent 79eb6c0
commit 20fb08e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/16401.misc b/changelog.d/16401.misc
@@ -0,0 +1 @@
+Downgrade replication stream time out error log lines to warning.
diff --git a/synapse/replication/tcp/client.py b/synapse/replication/tcp/client.py
@@ -339,7 +339,7 @@ async def wait_for_stream_position(
             try:
                 await make_deferred_yieldable(deferred)
             except defer.TimeoutError:
-                logger.error(
+                logger.warning(
                     "Timed out waiting for repl stream %r to reach %s (%s)"
                     "; currently at: %s",
                     stream_name,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Downgrade replication stream time out error log lines to warning.