Satisfy revised MSC4157 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
requested changes
Jul 25, 2024
|
Yes, I'll be pushing more commits here, for the rest of the revisions to MSC4157. I'll mark it as draft until that's done. |
timeout to delay & futureId to delayId
AndrewFerr
changed the title
Use type checks to disallow arbitrary string values as actions
|
The last batch of commits includes the widget API action for updating delayed events, which is the last thing that was missing to satisfy the MSC. This should be good to go now. |
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 30, 2024
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 30, 2024
AndrewFerr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Jul 30, 2024
4 tasks
toger5
approved these changes
Jul 30, 2024
Co-authored-by: Timo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the recent revisions to MSC4140/4157.
Another PR will be made for adding a widget capability for using the now-authenticated endpoint for sending/canceling/refreshing a future.This PR also includes the widget action & capability for sending/canceling/refreshing a delayed event.Signed-off-by: Andrew Ferrazzutti [email protected]