test(crypto): Add some basic snapshot testing in crypto crate #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
requested review from
bnjbvr and
poljar
and removed request for
a team
poljar
approved these changes
Dec 20, 2024
| let decryption_key = BackupDecryptionKey { inner: Box::new([1u8; 32]) }; | ||
| assert_json_snapshot!(decryption_key); | ||
|
|
||
| // should not log the key ! |
BillCarsonFr
force-pushed
the
valere/add_some_crypto_insta_snapshot_tests
branch
from
01bf4ba to
4e6c060
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4449 +/- ##
==========================================
+ Coverage 85.03% 85.05% +0.01%
==========================================
Files 283 283
Lines 31748 31748
==========================================
+ Hits 26998 27002 +4
+ Misses 4750 4746 -4 ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some snapshot testing for the crypto test.
Another benefit of insta is we see right away how things are serialised, and 2 findings here:
KnownSenderDataserializes the master_key as an array of numbers in json :/BackupDecryptionKeydoes it too, but it is never serialized by itself (but usingserialize_with). It probably doesn't need to be serializable by itself?Public API changes documented in changelogs (optional)
Signed-off-by: