test(event cache): rely less on EventCache::add_initial_events()
#4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it a smoke test that the event cache correctly gets events it retrieves from sync.
…nd event cache storage
…_initial_items` Moar MatrixMockServer \o/
… storage has been enabled Not worth testing IMO, since this is about the "temporary" API we're going to remove in subsequent patches.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4372 +/- ##
=======================================
Coverage 85.14% 85.14%
=======================================
Files 280 280
Lines 30764 30766 +2
=======================================
+ Hits 26195 26197 +2
Misses 4569 4569 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Dec 3, 2024
Comment on lines
178
to
185
| Update::NewItemsChunk { previous: None, new: ChunkIdentifier::new(0), next: None }, | ||
| Update::PushItems { | ||
| at: Position::new(ChunkIdentifier::new(0), 0), | ||
| items: vec![ | ||
| f.text_msg("hey there").sender(dexter).into_sync(), | ||
| f.text_msg("hoy!").sender(ivan).into_sync(), | ||
| ], | ||
| }, |
There was a problem hiding this comment.
I wonder if we shouldn't use a builder for that 🤔, thoughts?
There was a problem hiding this comment.
I think we could even avoid that by using a sync, and let the event cache store the events in memory.
bnjbvr
force-pushed
the
bnjbvr/rely-less-on-add-initial-events
branch
from
e8a4ce0 to
bdda880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventCache::add_initial_events()was supposed to be temporary, until the event cache has its own storage. It's been used in multiple tests, as a way to prefill the event cache. It's used in other place, when constructing a timeline, to prefill the room event cache with the (soon-to-be-deprecated) cached timeline we stored in the sliding sync storage (akatimeline_queue()).This patch gets rids of all uses in tests, so that there remains only a single use (when creating the timeline). We can later remove this function, once the storage has been enabled unconditionally.
Part of #3280
Split from #4308.