test: make the EventFactory available to all crates
#4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4296 +/- ##
==========================================
- Coverage 85.04% 85.03% -0.01%
==========================================
Files 274 274
Lines 30114 29977 -137
==========================================
- Hits 25610 25491 -119
+ Misses 4504 4486 -18 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
bnjbvr
force-pushed
the
bnjbvr/test-utils
branch
from
e441e75 to
83a8ad6
Compare
Hywan
approved these changes
Nov 20, 2024
| @@ -44,7 +44,7 @@ wasm-bindgen = "0.2.84" | |||
| [dev-dependencies] | |||
| assert_matches = { workspace = true } | |||
| proptest = { version = "1.4.0", default-features = false, features = ["std"] } | |||
| matrix-sdk-test = { workspace = true } | |||
| matrix-sdk-test-macros = { path = "../../testing/matrix-sdk-test-macros" } | |||
| @@ -21,7 +21,7 @@ http = { workspace = true } | |||
| matrix-sdk-common = { path = "../../crates/matrix-sdk-common" } | |||
| matrix-sdk-test-macros = { version = "0.7.0", path = "../matrix-sdk-test-macros" } | |||
| once_cell = { workspace = true } | |||
| ruma = { workspace = true, features = ["rand"] } | |||
| ruma = { workspace = true, features = ["rand", "unstable-msc3381"] } | |||
There was a problem hiding this comment.
Enabling support for polls when the crate is built independently. I'll add a comment.
bnjbvr
force-pushed
the
bnjbvr/test-utils
branch
from
f33e9b8 to
81b2b9b
Compare
bnjbvr
requested review from
richvdh
and removed request for
a team and
richvdh
This is more in line with what we're doing in the SDK in general.
The (matrix-sdk-)common crate used the (matrix-sdk-)test crate only to benefit from the `async_test` proc macro, which is conveniently defined in another crate. My goal is to make `EventFactory`, at this point in the commit history, defined in the main SDK crate, available in the test crate. `EventFactory` makes use of some types defined in common, so there's a circular dependency at the moment. To split this circular dependency, I've changed the common crate to depend on the test-macro crate directly; now the test crate can depend on the common crate, and everybody's happy.
bnjbvr
force-pushed
the
bnjbvr/test-utils
branch
from
81b2b9b to
cf03eea
Compare
This makes it available to the crypto crate, by lowering it into the local dependency tree.
… evaluation requirements
bnjbvr
force-pushed
the
bnjbvr/test-utils
branch
from
cf03eea to
85fb3b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had been requested by crypto folks in the past, notably @BillCarsonFr if I remember correctly: it makes the
EventFactoryavailable from all crates, by moving it intomatrix-sdk-test. Because the common crate depended on the test crate, andEventFactorydepends on thecommoncrate, this required cutting the circular dependency by having the common crate use the test-macro crate directly. I find it an acceptable tradeoff.The two first commits tidy up the test utils implemented in the SDK crate. I don't think they can be moved to another external crate:
Client,So we'd have a circular dependency there too, if we moved this code to another crate (unless I'm missing something).