Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Add a tutorial to the crypto crate #2352

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jul 28, 2023

No description provided.

@poljar poljar force-pushed the poljar/crypto-tutorial branch from 89ddb9d to e5f4cf6 Compare July 28, 2023 14:43
@bnjbvr bnjbvr changed the title Add a tutorial to the crypto crate crypto: Add a tutorial to the crypto crate Sep 3, 2024
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on principle (have only skimmed it, looks good to me but I'm not crypto expert), we shouldn't have to wait for docs lingering in PRs for so long. Thanks for writing this 🙏

@poljar poljar force-pushed the poljar/crypto-tutorial branch from e5f4cf6 to 3287cae Compare November 22, 2024 16:33
@poljar poljar marked this pull request as ready for review November 22, 2024 16:33
@poljar poljar requested review from a team as code owners November 22, 2024 16:33
@poljar poljar requested review from jmartinesp and andybalaam and removed request for a team November 22, 2024 16:33
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (48fbda8) to head (1773625).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
- Coverage   85.13%   85.07%   -0.06%     
==========================================
  Files         274      274              
  Lines       30190    30190              
==========================================
- Hits        25701    25685      -16     
- Misses       4489     4505      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Changelog: Add a tutorial describing how to add end-to-end encryption
support to an existing library.
@poljar poljar force-pushed the poljar/crypto-tutorial branch from 6c57cdd to 1773625 Compare November 22, 2024 17:01
@poljar poljar enabled auto-merge (rebase) November 22, 2024 17:01
@poljar poljar merged commit e55a1c7 into main Nov 22, 2024
40 checks passed
@poljar poljar deleted the poljar/crypto-tutorial branch November 22, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants