Skip to content

Commit

Permalink
Mark push_media as being OKAY despite having many arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Salinas committed Dec 11, 2024
1 parent cdac788 commit df7fc6e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
31 changes: 15 additions & 16 deletions crates/matrix-sdk-sqlite/src/state_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2408,22 +2408,21 @@ mod migration_tests {
let wedge_tx = wedged_event_transaction_id.clone();
let local_tx = local_event_transaction_id.clone();

let _ = conn
.with_transaction(move |txn| {
add_dependent_send_queue_event_v7(
&db,
txn,
room_id,
&local_tx,
ChildTransactionId::new(),
DependentQueuedRequestKind::RedactEvent,
)?;
add_send_queue_event_v7(&db, txn, &wedge_tx, room_id, true)?;
add_send_queue_event_v7(&db, txn, &local_tx, room_id, false)?;
Result::<_, Error>::Ok(())
})
.await
.unwrap();
conn.with_transaction(move |txn| {
add_dependent_send_queue_event_v7(
&db,
txn,
room_id,
&local_tx,
ChildTransactionId::new(),
DependentQueuedRequestKind::RedactEvent,
)?;
add_send_queue_event_v7(&db, txn, &wedge_tx, room_id, true)?;
add_send_queue_event_v7(&db, txn, &local_tx, room_id, false)?;
Result::<_, Error>::Ok(())
})
.await
.unwrap();
}

// This transparently migrates to the latest version, which clears up all
Expand Down
1 change: 1 addition & 0 deletions crates/matrix-sdk/src/send_queue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1181,6 +1181,7 @@ impl QueueStorage {
/// Push requests (and dependents) to upload a media.
///
/// See the module-level description for details of the whole processus.
#[allow(clippy::too_many_arguments)]
async fn push_media(
&self,
event: RoomMessageEventContent,
Expand Down

0 comments on commit df7fc6e

Please sign in to comment.