refactor(ui): Timeline receives pagination events as VectorDiffs!

This patch allows the paginated events of a `Timeline` to be received via `RoomEventCacheUpdate::UpdateTimelineEvents` as `VectorDiff`s.
matrix-org · Dec 17, 2024 · c44c178 · c44c178
1 parent e27b2b3
commit c44c178
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/crates/matrix-sdk-ui/src/timeline/controller/mod.rs b/crates/matrix-sdk-ui/src/timeline/controller/mod.rs
@@ -124,7 +124,7 @@ pub(super) struct TimelineController<P: RoomDataProvider = Room> {
     pub(crate) room_data_provider: P,
 
     /// Settings applied to this timeline.
-    settings: TimelineSettings,
+    pub(super) settings: TimelineSettings,
 }
 
 #[derive(Clone)]

diff --git a/crates/matrix-sdk-ui/src/timeline/pagination.rs b/crates/matrix-sdk-ui/src/timeline/pagination.rs
@@ -77,12 +77,16 @@ impl super::Timeline {
                     let num_events = events.len();
                     trace!("Back-pagination succeeded with {num_events} events");
 
-                    // TODO(hywan): Remove, and let spread events via
-                    // `matrix_sdk::event_cache::RoomEventCacheUpdate` from
-                    // `matrix_sdk::event_cache::RoomPagination::run_backwards`.
-                    self.controller
-                        .add_events_at(events.into_iter(), TimelineNewItemPosition::Start { origin: RemoteEventOrigin::Pagination })
-                        .await;
+                    // If `TimelineSettings::vectordiffs_as_inputs` is enabled,
+                    // we don't need to add events manually: everything we need
+                    // is to let the `EventCache` receives the events from this
+                    // pagination, and emits its updates as `VectorDiff`s, which
+                    // will be handled by the `Timeline` naturally.
+                    if !self.controller.settings.vectordiffs_as_inputs {
+                        self.controller
+                            .add_events_at(events.into_iter(), TimelineNewItemPosition::Start { origin: RemoteEventOrigin::Pagination })
+                            .await;
+                    }
 
                     if num_events == 0 && !reached_start {
                         // As an exceptional contract: if there were no events in the response,