Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further shrink the WASM output by using more aggressive optimizations #172

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Dec 2, 2024

This is significantly more expensive at compilation time, but shrinks the size of the WASM file from 6MB to 5MB (2.6MB to 1.8MB compressed).

@sandhose sandhose requested a review from a team as a code owner December 2, 2024 09:24
@sandhose sandhose requested a review from bnjbvr December 2, 2024 09:24
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any rough measurements of the compile times before/after this change? Thanks, lgtm in any case 👍

@sandhose
Copy link
Member Author

sandhose commented Dec 2, 2024

Do you have any rough measurements of the compile times before/after this change? Thanks, lgtm in any case 👍

Looks the cargo build part of the run took 2m07 on the build, and the previous one on the main branch took 1m39s

@sandhose sandhose merged commit 62e004f into main Dec 2, 2024
3 checks passed
@sandhose sandhose deleted the quenting/shrink-wasm branch December 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants