Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4133 - Extended profiles #4391

Merged
merged 8 commits into from
Sep 9, 2024
Merged

MSC4133 - Extended profiles #4391

merged 8 commits into from
Sep 9, 2024

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Sep 6, 2024 •
edited
Loading

Disclaimer: This is being worked on with an open source community hat on rather than my Element hat.

For matrix-org/matrix-spec-proposals#4133

While this MSC is in review, I opted to make new methods rather than extend the existing profile methods. I'm open to changing this if that seems more appropriate, but I think it's just as easy to change the methods later once the endpoint stabilizes.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • [N/A] Sign-off given on the changes (see CONTRIBUTING.md).

@Half-Shot Half-Shot marked this pull request as ready for review September 9, 2024 09:12
@Half-Shot Half-Shot requested a review from a team as a code owner September 9, 2024 09:12
dbkr
dbkr reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise this looks good I think

src/client.ts Outdated
{},
profile,
{
prefix: (await this.doesServerSupportUnstableFeature("uk.tcpip.msc4133.stable"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit repetitive - maybe a extendedProfilePrefix or something would be useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

src/models/profile-keys.ts Show resolved Hide resolved
dbkr
dbkr approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbkr dbkr added this pull request to the merge queue Sep 9, 2024
Merged via the queue into develop with commit e8128d3 Sep 9, 2024
26 checks passed
@dbkr dbkr deleted the hs/msc4133 branch September 9, 2024 12:22
@Half-Shot Half-Shot mentioned this pull request Sep 10, 2024
Merged
4 tasks
@tcpipuk tcpipuk mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @dbkr