Various formatting adjustments #1822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 12, 2024 12:06
Usually, IRC users just upload files somewhere and send a bare link, perhaps with a bit of explanation. The bridge originally did something like this for files: * f_[mtrx] uploaded an image: (20KiB) < https://matrix.org/_matrix/media/v3/download/something/some-other-thing/image.png > and something like this for code blocks: * f_[mtrx] sent a code block: https://matrix.org/_matrix/media/v3/download/something/some-other-thing That is quite unusual on IRC. This commit changes it to: <f_[mtrx]> https://matrix.org/_matrix/media/v3/download/something/some-other-thing/image.png (20KiB) <f_[mtrx]> https://matrix.org/_matrix/media/v3/download/something/some-other-thing Which is more natural. Signed-off-by: Ferass El Hafidi <[email protected]>
It previously was: <f_> hi everyone, what's up? I'm about to migrate some stuff today ~ a while after ~ <f_[mtrx]> <f_> "hi everyone,..." <- hi, doing great! Now it is: <f_> hi everyone, what's up? I'm about to migrate some stuff today ~ a while after ~ <f_[mtrx]> f_: "hi everyone,..." <- hi, doing great! Some IRC clients may not create a ping when the nickname is surrounded with `<` and `>`. Signed-off-by: Ferass El Hafidi <[email protected]>
starts with an invalid character Looks more natural to IRC users. IRC users usually add an underscore at the beginning or a "`". With that, "M24Hacker[m]" becomes "`24Hacker[m]" Signed-off-by: Ferass El Hafidi <[email protected]>
Fixes #1521 Signed-off-by: Ferass El Hafidi <[email protected]>
When someone sent a message: <f_[mtrx]> Hello? And then replied to their own message: <f_[mtrx]> > <@Funderscore:nova.astraltech.org> Hello? Hi? What would be sent on IRC would either be this: <f_[mtrx]> Hello? <f_[mtrx]> f_[mtrx]: Hi? Or: <f_[mtrx]> Hello? -- a while later -- <f_[mtrx]> f_[mtrx]: "Hello?" <- Hi? Both of which are confusing because usually nobody pings themself on IRC. This commit treats replies to self differently, and introduces a new `selfReplyTemplate` config option, so that the reply gets bridged as: <f_[mtrx]> <f_[mtrx]> Hello? <f_[mtrx]> Hi? Which is a bit more natural. Signed-off-by: Ferass El Hafidi <[email protected]>
Signed-off-by: Ferass El Hafidi <[email protected]>
Signed-off-by: Ferass El Hafidi <[email protected]>
Signed-off-by: Ferass El Hafidi <[email protected]>
Signed-off-by: Ferass El Hafidi <[email protected]>
tadzik
force-pushed
the
1807-split/formatting-adjustments
branch
from
509aae1 to
4bb409e
Compare
tadzik
commented
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting-related changes from #1807, including:
Credit to @funderscore1