Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last run metric being wrong #207

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix last run metric being wrong #207

merged 2 commits into from
Jan 3, 2024

Conversation

Half-Shot
Copy link
Contributor

Wrong variable, wrong type. It was incrementing by the current epoch every time this ran, so basically useless!

@Half-Shot Half-Shot requested a review from a team as a code owner December 19, 2023 11:15
H-Shay
H-Shay approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@H-Shay H-Shay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Half-Shot Half-Shot merged commit d154cdf into main Jan 3, 2024
5 checks passed
@Half-Shot Half-Shot deleted the hs/fix-last-run-metrics branch January 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H-Shay H-Shay H-Shay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @H-Shay