Upload mitmdump files as artifacts #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows HTTP flows from CI runs to be viewed. Fixes #80. Also changes the upload version to v4 because: - v2 is deprecated on June 30, 2024. - v4 has faster uploads - v4 artifacts are shown immediately in the web UI, whereas v2 needs the job to complete before showing. However, v4 artifacts are immutable so we cannot upload artifacts with the same name. Instead, rename the artifact depending on the SDK tested.
andybalaam
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows HTTP flows from CI runs to be viewed. Fixes #80.
Also changes the upload version to v4 because:
However, v4 artifacts are immutable so we cannot upload artifacts with the same name. Instead, rename the artifact depending on the SDK tested.