Revert changes to Cargo files when rebuilding rust SDK #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As complement-crypto needs an earlier version of uniffi, it needs to tweak the deps at build time. Revert them afterwards.
richvdh
approved these changes
Jul 9, 2024
Comment on lines
48
to
50
| sed -i.bak 's/uniffi =.*/uniffi = "0\.25\.3"/' Cargo.toml | ||
| sed -i.bak 's^uniffi_bindgen =.*^uniffi_bindgen = { git = "https:\/\/github.com\/mozilla\/uniffi-rs", rev = "0a03b713306d6ce3de033157fc2ce92a238c2e24" }^' Cargo.toml | ||
| sed -i.bak 's#matrix-sdk-crypto = {#matrix-sdk-crypto = {features = ["_disable-minimum-rotation-period-ms"],#' Cargo.toml |
There was a problem hiding this comment.
given -i.bak gives you a backup, maybe you could save the separate cp operation. You would have to combine the sed commands into one, but that should be fine?
There was a problem hiding this comment.
I'm using -i.bak in particular for portability reasons. FreeBSD/Mac demands -i has a suffix, but GNU does not. It's not standardised at all, so I'm reluctant to rely on it for providing backups.
There was a problem hiding this comment.
Surely the fact that you're successfully using it means that it must be accepted? Are you really concerned that there might be implementations of sed that accept a suffix to -i but ignore it?
Not that this really matters, it just feels odd to duplicate the backup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As complement-crypto needs an earlier version of uniffi, it needs to tweak the deps at build time. Revert them afterwards.