Skip to content

Commit

Permalink
Unskip tests now that the bugs are fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
kegsay committed May 15, 2024
1 parent 11999c1 commit 71f704b
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions tests/notification_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ func TestMultiprocessNSEBackupKeyMacError(t *testing.T) {
t.Skipf("rust only")
return
}
t.Skipf("pending bugfix")
tc, roomID := createAndJoinRoom(t)
// Alice starts syncing to get an encrypted room set up
alice := tc.MustLoginClient(t, tc.Alice, tc.AliceClientType, WithPersistentStorage(), WithCrossProcessLock("main"))
Expand Down Expand Up @@ -441,23 +440,19 @@ func TestMultiprocessDupeOTKUpload(t *testing.T) {
t.Skipf("rust only")
return
}
t.Skipf("WIP")
tc, roomID := createAndJoinRoom(t)

// start the "main" app
alice := tc.MustLoginClient(t, tc.Alice, tc.AliceClientType, WithPersistentStorage(), WithCrossProcessLock("main"))
aliceAccessToken := alice.Opts().AccessToken

// let OTKs be uploaded
time.Sleep(time.Second)

// prep nse process
nseAlice := tc.MustCreateMultiprocessClient(t, tc.AliceClientType.Lang, tc.ClientCreationOpts(t, tc.Alice, tc.AliceClientType.HS,
WithPersistentStorage(), WithAccessToken(aliceAccessToken), WithCrossProcessLock(api.ProcessNameNSE),
))

aliceUploadedNewKeys := false
// artificially slow down the HTTP responses, such that we will have 2 in-flight /keys/upload requests
// artificially slow down the HTTP responses, such that we will potentially have 2 in-flight /keys/upload requests
// at once. If the NSE and main apps are talking to each other, they should be using the same key ID + key.
// If not... well, that's a bug because then the client will forget one of these keys.
tc.Deployment.WithSniffedEndpoint(t, "/keys/upload", func(cd deploy.CallbackData) {
Expand Down

0 comments on commit 71f704b

Please sign in to comment.