Support NextRequest and NextResponse
#524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I almost figured out the implementation myself but then I find out this pull request. Checked the commits and they look logical. I wonder when will it be merged? @maticzav |
|
It would be great to get a review on this PR? I would love to use the new _middleware feature with Nookies |
|
Hello all, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Next.js's middleware (
_middleware.jsetc.), we useNextRequestandNextResponseas contexts. I want to pass them tonookies.get/setin the same style as others, so I added support for them inparseCookiesandsetCookie.Also, I upgraded
nextversion in dependencies so that the TypeScript compiler can refer toNextRequestandNextResponsethat are newer features.By this PR, #507 will be closed.