button "Review ignored people" to review again ignored/hidden persons #747
Conversation
…eople. This button only appears when ignored/hidden people are found. Signed-off-by: wronny <[email protected]>
|
Ohh. Great addition @wronny These days I will do a review. At first glance I like it, and I just don't understand that sleep(1). 🤔 but if everything is fine I'll probably merge it and then make some changes. 😉 |
if both - new and ignored persons are found - I experienced a random order of both buttons. To delay checking for ignored/hidden persons was a quick workaround to have "Review ignored people" always as second button. |
|
Hi @wronny Thanks again.. |
It is a minimal improvement on how the application should always have been. Instead of getting the information at the start of the application, we do it only when we know there are values and the user wants to do something with it. This also applies to the user's enablement value as well as to the set of new people to recognize.
|
Done.. See last commit.. Thanks again. With this tomorrow I will upload a new release. 😉 |
Hi,
I agree on #735 - currently ignored/hidden people can only be shown again by making a change within the database. Therefore I added a button "Review ignored people" to review again ignored/hidden persons. This button only appears when ignored/hidden people are found.
I hope this will be helpful.