Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some deprecated API #4228

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Dec 17, 2024

Summary

Replace some deprecated API:

  • spglib dict interface
  • Revert deprecation warning as error

@DanielYang59 DanielYang59 marked this pull request as ready for review December 17, 2024 12:10
@DanielYang59 DanielYang59 force-pushed the migrate-deprecated-spglib-dict-interface branch from 0818b17 to 36a32f0 Compare December 20, 2024 10:27
@mkhorton
Copy link
Member

Thanks @DanielYang59!

@mkhorton mkhorton enabled auto-merge (squash) December 22, 2024 22:31
@shyuep shyuep disabled auto-merge December 31, 2024 22:18
@shyuep shyuep merged commit 3be22d0 into materialsproject:master Dec 31, 2024
4 of 5 checks passed
@DanielYang59 DanielYang59 deleted the migrate-deprecated-spglib-dict-interface branch January 1, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants