Reapply zopen explicit UTF-8 encoding, enable optional EncodingWarning PEP 597 in tests
#4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
changed the title
zopen explicit encoding and fix CI failurezopen explicit encoding
DanielYang59
changed the title
zopen explicit encodingzopen explicit UTF-8 encoding
1 task
DanielYang59
commented
Dec 12, 2024
DanielYang59
commented
Dec 12, 2024
DanielYang59
changed the title
zopen explicit UTF-8 encodingzopen explicit UTF-8 encoding, enable optional EncodingWarning PEP 597
DanielYang59
changed the title
zopen explicit UTF-8 encoding, enable optional EncodingWarning PEP 597zopen explicit UTF-8 encoding, enable optional EncodingWarning PEP 597 in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zopen: explicit binary/textmode, and explicitencodingas UTF-8 #4219, in response to Revert "zopen: explicit binary/textmode, and explicitencodingas UTF-8" #4221PYTHONWARNDEFAULTENCODINGPEP 597, markmonty.io.zopenencoding warning as error, confirmed to work by https://github.com/materialsproject/pymatgen/actions/runs/12297641499montydropped custom encoding warning, modify warning filter