Skip to content

Commit

Permalink
make global var all cap
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielYang59 committed Dec 24, 2024
1 parent 826b9f4 commit ee3f0f7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/pymatgen/command_line/gulp_caller.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
__status__ = "Production"
__date__ = "Jun 22, 2013M"

_anions = set(map(Element, ["O", "S", "F", "Cl", "Br", "N", "P"]))
_cations = set(
_ANIONS = set(map(Element, ["O", "S", "F", "Cl", "Br", "N", "P"]))
_CATIONS = set(
map(
Element,
[
Expand Down Expand Up @@ -158,7 +158,7 @@ def structure_lines(
specie = site.specie
core_site_desc = f"{specie.symbol} core {' '.join(coord)}\n"
gin += core_site_desc
if (specie in _anions and anion_shell_flg) or (specie in _cations and cation_shell_flg):
if (specie in _ANIONS and anion_shell_flg) or (specie in _CATIONS and cation_shell_flg):
shel_site_desc = f"{specie.symbol} shel {' '.join(coord)}\n"
gin += shel_site_desc
else:
Expand Down

0 comments on commit ee3f0f7

Please sign in to comment.