don't allow subclass

materialsproject · Dec 24, 2024 · 3474e79 · 3474e79
1 parent 7f69553
commit 3474e79
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/tests/analysis/test_pourbaix_diagram.py b/tests/analysis/test_pourbaix_diagram.py
@@ -353,5 +353,4 @@ def test_solid(self):
         assert ion_or_solid_comp_object("Fe(s)") == Composition("Fe1")
 
         # Test end without "(s)"
-        # TODO: Na2O should be Composition instead of Ion?
-        assert ion_or_solid_comp_object("Na2O") == Ion.from_formula("Na2O")
+        assert type(ion_or_solid_comp_object("Na2O")) is Composition