solution #1565
Open
solution #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TargoniyAnatoliy
approved these changes
Dec 23, 2024
|
|
||
| const USER_ID = 0; | ||
| export enum FilterParam { | ||
| All = 'All', |
There was a problem hiding this comment.
You can remove FilterParam into types folder and use it instead type Filter
| export const updateTodo = (todoId: number, todo: Todo) => { | ||
| return client.patch(`/todos/${todoId}`, todo); | ||
| }; | ||
| // Add more methods here |
StasSokolov1
suggested changes
Dec 23, 2024
| }; | ||
|
|
||
| export const updateTodo = (todoId: number, todo: Todo) => { | ||
| return client.patch(`/todos/${todoId}`, todo); |
There was a problem hiding this comment.
let's move /todos into const and reuse
| htmlFor={`${id}`} | ||
| className="todo__status-label" | ||
| onClick={() => | ||
| handleUpdateTodo(id, title, completed ? false : true) |
There was a problem hiding this comment.
Suggested change
| handleUpdateTodo(id, title, completed ? false : true) | |
| handleUpdateTodo(id, title, completed) |
it can be a bit simplify
| id: number, | ||
| completed: boolean, | ||
| ) => { | ||
| if (event.key === 'Enter') { |
There was a problem hiding this comment.
will be good move Enter into const or enum like Keys as we use this in several places
|
|
||
| const handleBlur = (id: number, completed: boolean) => { | ||
| setIsEditing(null); | ||
| if (newTitle.length === 0) { |
There was a problem hiding this comment.
Suggested change
| if (newTitle.length === 0) { | |
| if (!!newTitle.length) { |
can be a bit simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK