Develop #1564
Open
Develop #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Dec 23, 2024
src/App.tsx
Outdated
Comment on lines
46
to
48
| .then(todosFromServer => { | ||
| setTodos(todosFromServer); | ||
| }) |
There was a problem hiding this comment.
Suggested change
| .then(todosFromServer => { | |
| setTodos(todosFromServer); | |
| }) | |
| .then(setTodos) |
src/App.tsx
Outdated
Comment on lines
116
to
118
| // const isSuccess = results | ||
| // .filter(result => result.status === 'fulfilled') | ||
| // .map((_, index) => completedTodos[index].id); |
There was a problem hiding this comment.
Remove all comments
Suggested change
| // const isSuccess = results | |
| // .filter(result => result.status === 'fulfilled') | |
| // .map((_, index) => completedTodos[index].id); |
src/App.tsx
Outdated
|
|
||
| const USER_ID = 0; | ||
| function filterTodos(todos: Todo[], filterBy: string) { | ||
| const copy = [...todos]; |
There was a problem hiding this comment.
Don't need to create a copy for todos, method filter returns new array
I actually did, but did not get a helpful answer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Same as with last task, I didn`t pass 2 tests, but I did others