-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final version #1563
Open
AsyaDev14
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
AsyaDev14:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+607
−22
Open
final version #1563
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,167 @@ | ||
/* eslint-disable max-len */ | ||
/* eslint-disable jsx-a11y/label-has-associated-control */ | ||
/* eslint-disable jsx-a11y/control-has-associated-label */ | ||
import React from 'react'; | ||
import { UserWarning } from './UserWarning'; | ||
|
||
const USER_ID = 0; | ||
import React, { useEffect, useState, useMemo } from 'react'; | ||
import { Todo } from './types/Todo'; | ||
import { | ||
USER_ID, | ||
addTodo, | ||
deleteTodo, | ||
getTodos, | ||
updateTodo, | ||
} from './api/todos'; | ||
import { ErrorStatus } from './types/ErrorStatus'; | ||
import { Status } from './types/Status'; | ||
import { Header } from './components/Header'; | ||
import { Footer } from './components/Footer'; | ||
import { ErrorNotification } from './components/ErrorNotification'; | ||
import { TodoList } from './components/TodoList'; | ||
|
||
export const App: React.FC = () => { | ||
if (!USER_ID) { | ||
return <UserWarning />; | ||
} | ||
const [todoList, setTodoList] = useState<Todo[]>([]); | ||
const [error, setError] = useState<ErrorStatus>(ErrorStatus.Empty); | ||
const [filter, setFilter] = useState<Status>(Status.All); | ||
const [tempTodo, setTempTodo] = useState<Todo | null>(null); | ||
const [loadingTodoIds, setLoadingTodoIds] = useState<number[]>([]); | ||
|
||
useEffect(() => { | ||
getTodos() | ||
.then(setTodoList) | ||
.catch(() => { | ||
setError(ErrorStatus.UnableToLoad); | ||
}); | ||
}, []); | ||
|
||
const todosActiveNum = useMemo( | ||
() => todoList.filter(todo => !todo.completed).length, | ||
[todoList], | ||
); | ||
|
||
const todosCompletedNum = useMemo( | ||
() => todoList.filter(todo => todo.completed).length, | ||
[todoList], | ||
); | ||
|
||
const allTodosCompleted = useMemo( | ||
() => todoList.length === todosCompletedNum, | ||
[todoList], | ||
); | ||
|
||
const handleAddTodo = async (todoTitle: string) => { | ||
setTempTodo({ id: 0, title: todoTitle, completed: false, userId: USER_ID }); | ||
try { | ||
const newTodo = await addTodo({ title: todoTitle, completed: false }); | ||
|
||
setTodoList(prev => [...prev, newTodo]); | ||
} catch (err) { | ||
setError(ErrorStatus.UnableToAdd); | ||
throw err; | ||
} finally { | ||
setTempTodo(null); | ||
} | ||
}; | ||
|
||
const handleRemoveTodo = async (todoId: number) => { | ||
setLoadingTodoIds(prev => [...prev, todoId]); | ||
try { | ||
await deleteTodo(todoId); | ||
setTodoList(prev => prev.filter(todo => todo.id !== todoId)); | ||
} catch (err) { | ||
setError(ErrorStatus.UnableToDelete); | ||
} finally { | ||
setLoadingTodoIds(prev => prev.filter(id => id !== todoId)); | ||
} | ||
}; | ||
|
||
const handleClearCompleted = async () => { | ||
const completedTodos = todoList.filter(todo => todo.completed); | ||
|
||
completedTodos.forEach(todo => { | ||
handleRemoveTodo(todo.id); | ||
}); | ||
}; | ||
|
||
const handleUpdatedTodo = async (todoToUpdate: Todo): Promise<void> => { | ||
setLoadingTodoIds(prev => [...prev, todoToUpdate.id]); | ||
try { | ||
const updatedTodo = await updateTodo(todoToUpdate); | ||
|
||
setTodoList(prev => | ||
prev.map(todoElem => | ||
todoElem.id === updatedTodo.id ? todoToUpdate : todoElem, | ||
), | ||
); | ||
// eslint-disable-next-line @typescript-eslint/no-shadow | ||
} catch (error) { | ||
setError(ErrorStatus.UnableToUpdate); | ||
throw error; | ||
} finally { | ||
setLoadingTodoIds(prev => prev.filter(id => id !== todoToUpdate.id)); | ||
} | ||
}; | ||
|
||
const handleToggleAll = async () => { | ||
if (todosActiveNum > 0) { | ||
const activeTodos = todoList.filter(todo => !todo.completed); | ||
|
||
activeTodos.forEach(todo => { | ||
handleUpdatedTodo({ ...todo, completed: true }); | ||
}); | ||
} else { | ||
todoList.forEach(todo => { | ||
handleUpdatedTodo({ ...todo, completed: false }); | ||
}); | ||
} | ||
}; | ||
|
||
const filteredTodoList = (): Todo[] => { | ||
switch (filter) { | ||
case Status.Active: | ||
return todoList.filter(todo => !todo.completed); | ||
case Status.Completed: | ||
return todoList.filter(todo => todo.completed); | ||
default: | ||
return todoList; | ||
} | ||
}; | ||
|
||
return ( | ||
<section className="section container"> | ||
<p className="title is-4"> | ||
Copy all you need from the prev task: | ||
<br /> | ||
<a href="https://github.com/mate-academy/react_todo-app-add-and-delete#react-todo-app-add-and-delete"> | ||
React Todo App - Add and Delete | ||
</a> | ||
</p> | ||
|
||
<p className="subtitle">Styles are already copied</p> | ||
</section> | ||
<div className="todoapp"> | ||
<h1 className="todoapp__title">todos</h1> | ||
|
||
<div className="todoapp__content"> | ||
<Header | ||
onAddTodo={handleAddTodo} | ||
setErrorMessage={setError} | ||
todoLength={todoList.length} | ||
todoList={todoList} | ||
onToggleAll={handleToggleAll} | ||
allTodosCompleted={allTodosCompleted} | ||
/> | ||
|
||
{(!!todoList.length || tempTodo) && ( | ||
<> | ||
<TodoList | ||
filteredTodoList={filteredTodoList()} | ||
loadingTodoIds={loadingTodoIds} | ||
tempTodo={tempTodo} | ||
handleRemoveTodo={handleRemoveTodo} | ||
handleUpdatedTodo={handleUpdatedTodo} | ||
/> | ||
|
||
<Footer | ||
todosCounter={todosActiveNum} | ||
filterStatus={filter} | ||
setFilter={setFilter} | ||
onClearCompleted={handleClearCompleted} | ||
showClearCompletedButton={todoList.some(todo => todo.completed)} | ||
/> | ||
</> | ||
)} | ||
</div> | ||
|
||
<ErrorNotification error={error} setError={setError} /> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { Todo } from '../types/Todo'; | ||
import { client } from '../utils/fetchClient'; | ||
|
||
export const USER_ID = 2138; | ||
|
||
export const getTodos = () => { | ||
return client.get<Todo[]>(`/todos?userId=${USER_ID}`); | ||
}; | ||
|
||
export const addTodo = (newTodo: Omit<Todo, 'id' | 'userId'>) => { | ||
return client.post<Todo>(`/todos`, { ...newTodo, userId: USER_ID }); | ||
}; | ||
|
||
export const deleteTodo = (todoId: number) => { | ||
return client.delete(`/todos/${todoId}`); | ||
}; | ||
|
||
export const updateTodo = (todo: Todo) => { | ||
return client.patch<Todo>(`/todos/${todo.id}`, todo); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import React, { useEffect } from 'react'; | ||
import { ErrorStatus } from '../types/ErrorStatus'; | ||
import cn from 'classnames'; | ||
|
||
type Props = { | ||
error: string; | ||
setError: React.Dispatch<React.SetStateAction<ErrorStatus>>; | ||
}; | ||
|
||
export const ErrorNotification: React.FC<Props> = props => { | ||
const { error, setError } = props; | ||
|
||
useEffect(() => { | ||
if (error === ErrorStatus.Empty) { | ||
return; | ||
} | ||
|
||
const timerId = setTimeout(() => { | ||
setError(ErrorStatus.Empty); | ||
}, 3000); | ||
|
||
return () => { | ||
clearInterval(timerId); | ||
}; | ||
}, [error, setError]); | ||
|
||
return ( | ||
<div | ||
data-cy="ErrorNotification" | ||
className={cn( | ||
'notification', | ||
'is-danger', | ||
'is-light has-text-weight-normal', | ||
{ hidden: !error }, | ||
)} | ||
> | ||
<button | ||
data-cy="HideErrorButton" | ||
type="button" | ||
className="delete" | ||
onClick={() => setError(ErrorStatus.Empty)} | ||
/> | ||
{error} | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import React from 'react'; | ||
import { Status } from '../types/Status'; | ||
import cn from 'classnames'; | ||
|
||
interface Props { | ||
filterStatus: Status; | ||
setFilter: (value: Status) => void; | ||
todosCounter: number; | ||
onClearCompleted: () => Promise<void>; | ||
showClearCompletedButton: boolean; | ||
} | ||
|
||
export const Footer: React.FC<Props> = props => { | ||
const { | ||
setFilter, | ||
filterStatus, | ||
todosCounter, | ||
onClearCompleted, | ||
showClearCompletedButton, | ||
} = props; | ||
|
||
return ( | ||
<footer className="todoapp__footer" data-cy="Footer"> | ||
<span className="todo-count" data-cy="TodosCounter"> | ||
{todosCounter} items left | ||
</span> | ||
|
||
<nav className="filter" data-cy="Filter"> | ||
{Object.values(Status).map(filter => ( | ||
<a | ||
key={filter} | ||
href={`#/${filter === Status.All ? '' : filter.toLowerCase()}`} | ||
className={cn('filter__link', { | ||
selected: filterStatus === filter, | ||
})} | ||
data-cy={`FilterLink${filter}`} | ||
onClick={() => setFilter(filter)} | ||
> | ||
{filter} | ||
</a> | ||
))} | ||
</nav> | ||
|
||
<button | ||
type="button" | ||
className="todoapp__clear-completed" | ||
data-cy="ClearCompletedButton" | ||
onClick={onClearCompleted} | ||
disabled={!showClearCompletedButton} | ||
> | ||
Clear completed | ||
</button> | ||
</footer> | ||
); | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Hook useMemo has a missing dependency: 'todosCompletedNum'. Either include it or remove the dependency array
Actually you don't need to use
useMemo
here as it's a primitive value