Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #1556

wants to merge 3 commits into from

Conversation

Krrampuss
Copy link

VolodymyrKirichenko
VolodymyrKirichenko suggested changes Dec 23, 2024
View reviewed changes
Copy link

@VolodymyrKirichenko VolodymyrKirichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make some fixes 🥹

src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/Footer.tsx Outdated Show resolved Hide resolved
src/components/Header.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
StasSokolov1
StasSokolov1 suggested changes Dec 24, 2024
View reviewed changes
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, let's improve your code a bit more!

src/App.tsx Outdated Show resolved Hide resolved
src/api/todos.ts Outdated Show resolved Hide resolved
src/components/Header.tsx Outdated Show resolved Hide resolved
src/components/Header.tsx Outdated Show resolved Hide resolved
StasSokolov1
StasSokolov1 approved these changes Dec 24, 2024
View reviewed changes
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a masterpiece!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StasSokolov1 StasSokolov1 StasSokolov1 approved these changes

@VolodymyrKirichenko VolodymyrKirichenko Awaiting requested review from VolodymyrKirichenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krrampuss @StasSokolov1 @VolodymyrKirichenko