Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #1550

wants to merge 1 commit into from

Conversation

pogorielova
Copy link

Andrii-Yanchuk
Andrii-Yanchuk approved these changes Dec 20, 2024
View reviewed changes
Copy link

@Andrii-Yanchuk Andrii-Yanchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greate Job🔥

BudnikOleksii
BudnikOleksii approved these changes Dec 25, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
Approved, but left a few suggestions

src/App.tsx
Comment on lines +25 to +27
if (filterType === FilterType.All) {
return true;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to filter at all when filterType === FilterType.All

src/App.tsx
inputField={inputField}
onToggleAll={onToggleAll}
/>
<section className="todoapp__main" data-cy="TodoList">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a TodoList component

src/components/ErrorNotification.tsx
data-cy="ErrorNotification"
className={classNames(
'notification is-danger is-light has-text-weight-normal',
{ hidden: errorMessage === null },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ hidden: errorMessage === null },
{ hidden: !errorMessage },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrii-Yanchuk Andrii-Yanchuk Andrii-Yanchuk approved these changes

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pogorielova @BudnikOleksii @Andrii-Yanchuk