solution #1541
Open
solution #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welbrn
suggested changes
Dec 19, 2024
BudnikOleksii
suggested changes
Dec 22, 2024
src/App.tsx
Outdated
|
|
||
| const [inputText, setInputText] = useState(''); | ||
| const [filteredTodos, setFilteredTodos] = useState<Todo[]>([]); | ||
| const [statusChangeId, setStatusChangeId] = useState<number[]>([]); |
There was a problem hiding this comment.
Suggested change
| const [statusChangeId, setStatusChangeId] = useState<number[]>([]); | |
| const [loadingTodoIds, setLoadingTodoIds] = useState<number[]>([]); |
One state for todo ids is enough
src/App.tsx
Outdated
Comment on lines
74
to
80
| let boolFilter = null; | ||
|
|
||
| if (filter === Filter.Active) { | ||
| boolFilter = false; | ||
| } else if (filter === Filter.Completed) { | ||
| boolFilter = true; | ||
| } |
There was a problem hiding this comment.
Use switch case instead. And you can simplify this condition
src/App.tsx
Outdated
Comment on lines
93
to
97
| let changed = prev.map(todo => (todo.id === id ? updatedTodo : todo)); | ||
|
|
||
| if (todosState === setFilteredTodos) { | ||
| changed = filterTodosByStatus(changed, filter); | ||
| } |
There was a problem hiding this comment.
I have no idea what is happening here. Try to simplify
src/App.tsx
Outdated
| } | ||
|
|
||
| function handleTitleChange(newTitle: string, editingTodoId: number | null) { | ||
| const updateStatus = { title: newTitle }; |
There was a problem hiding this comment.
Why do you call it status when actually store a title?
src/App.tsx
Outdated
| const updateStatus = { title: newTitle }; | ||
|
|
||
| return client | ||
| .patch<Todo>(`/todos/${editingTodoId}`, updateStatus) |
There was a problem hiding this comment.
Create a function to do it. Your component shouldn't know anything about URL where you are sending the request
src/App.tsx
Outdated
| }); | ||
|
|
||
| function changeStatusAll() { | ||
| const status = isAllCompleted ? false : true; |
src/App.tsx
Outdated
| <h1 className="todoapp__title">todos</h1> | ||
|
|
||
| <div className="todoapp__content"> | ||
| <header className="todoapp__header"> |
src/App.tsx
Outdated
| /> | ||
| </form> | ||
| </header> | ||
| <section className="todoapp__main" data-cy="TodoList"> |
src/App.tsx
Outdated
|
|
||
| {/* Hide the footer if there are no todos +++*/} | ||
| {todos.length !== 0 && ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> |
src/api/todos.ts
Outdated
| return client.get<Todo[]>(`/todos?userId=${USER_ID}`); | ||
| }; | ||
|
|
||
| // Add more methods here |
StasSokolov1
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://save-v.github.io/react_todo-app-with-api/