Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution linter formatter #1832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution linter formatter #1832

wants to merge 1 commit into from

Conversation

YurievAndrii
Copy link

Solution for linter formatter

ihorhalyskiy
ihorhalyskiy reviewed Nov 26, 2024
View reviewed changes
app/main.py


def format_linter_report(linter_report: dict) -> list:
# write your code here
Copy link

@ihorhalyskiy ihorhalyskiy Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

ihorhalyskiy
ihorhalyskiy approved these changes Nov 26, 2024
View reviewed changes
app/main.py


def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

app/main.py
@@ -1,13 +1,27 @@
def format_linter_error(error: dict) -> dict:
# write your code here
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write cod here

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 26, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Your code in app/main.py meets all the task requirements and constraints. The functions are correctly implemented and formatted as specified. Keep up the excellent work! If you want to further improve, consider exploring additional best practices and optimizations in the future. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihorhalyskiy ihorhalyskiy ihorhalyskiy approved these changes

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YurievAndrii @mateacademy-ai-mentor @ihorhalyskiy