Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement py-linter-formatter #1829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

misha-cw
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this Pull Request! 😊 While your code is generally well-structured and meets most of the task requirements, there's a critical issue that needs to be addressed before we can approve it. The format_linter_report function uses the variable file_name without defining it in the loop. This could lead to errors when the function is executed. Please ensure that file_name is correctly defined and used within the loop, such as by using for file_name, errors in linter_report.items(). Once this is resolved, your code should be good to go! Keep up the great work, and I look forward to seeing your improvements! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

app/main.py Outdated Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on resolving the critical issue with the format_linter_report function in app/main.py! 🎉 The code is now well-structured and meets the task requirements. Although there were some issues initially, you've successfully addressed them, and the code now functions as expected.

To help you move forward with your learning, remember to review the comments provided to further improve your code. It's important to address any critical issues in future projects to avoid similar problems. Keep up the good work, and continue learning from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants