Solution #1658
Solution #1658
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 The core functionality is solid, and you've met the task requirements. Just a couple of minor improvements: ensure the type hints include int and float for better clarity, and handle division by zero with an exception. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| # / | ||
| def __truediv__(self, other: int | float) -> Distance: | ||
| if other == 0: | ||
| return Distance(other) |
There was a problem hiding this comment.
The __truediv__ method should raise an exception when dividing by zero instead of returning a Distance object with zero. Consider using raise ZeroDivisionError('division by zero').
| return Distance(km=result) | ||
|
|
||
| def __lt__(self, other: Distance) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
The type hint for the other parameter should include int and float as well as Distance. Update it to other: Distance | int | float.
| return self.km < other.km | ||
|
|
||
| def __gt__(self, other: Distance) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
The type hint for the other parameter should include int and float as well as Distance. Update it to other: Distance | int | float.
| return self.km > other.km | ||
|
|
||
| def __eq__(self, other: Distance) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
The type hint for the other parameter should include int and float as well as Distance. Update it to other: Distance | int | float.
| return self.km == other.km | ||
|
|
||
| def __le__(self, other: Distance) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
The type hint for the other parameter should include int and float as well as Distance. Update it to other: Distance | int | float.
| return self.km <= other.km | ||
|
|
||
| def __ge__(self, other: Distance) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
The type hint for the other parameter should include int and float as well as Distance. Update it to other: Distance | int | float.
No description provided.