Develop #1649
Open
Develop #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1ce5f59.
mateacademy-ai-mentor
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 The functionality is mostly correct, and you've met the task requirements well. Just a small note: consider refining the __truediv__ method to return a new Distance instance with an integer value for km to maintain consistency. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
+36
to
+37
| def __truediv__(self, divisor: int) -> Any: | ||
| self.km = round(self.km / divisor, 2) |
There was a problem hiding this comment.
The __truediv__ method assigns a float to self.km, which is expected to be an integer. Consider returning a new Distance instance with the rounded result instead of modifying self.km directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.