Solution #1648
Solution #1648
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class with all the required functionalities! 🎉 The class is well-structured, and you've successfully incorporated operator overloading for arithmetic and comparison operations. While there are minor issues with type hints in the __truediv__ and __mul__ methods, these do not impact the overall functionality. Keep up the excellent work, and consider refining the type hints for even better code clarity in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| return NotImplemented | ||
| return self | ||
|
|
||
| def __mul__(self, factor: "Distance") -> "Distance": |
There was a problem hiding this comment.
The type hint for the factor parameter in the __mul__ method should be (int, float) instead of "Distance", as this method is designed to multiply the distance by a numeric factor.
| else: | ||
| return NotImplemented | ||
|
|
||
| def __truediv__(self, divisor: "Distance") -> "Distance": |
There was a problem hiding this comment.
The type hint for the divisor parameter in the __truediv__ method should be (int, float) instead of "Distance", as this method is designed to divide the distance by a numeric divisor.
No description provided.