Ready solutions for all tasks #1638
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class with all the required magic methods! 🎉 The code meets the task requirements and constraints, and you've done well to follow the checklist guidelines. While there are a couple of minor issues, such as the redundant return statement in the __le__ method and the missing return statement in the __ge__ method, these do not significantly impact the functionality. Keep up the good work, and consider refining these areas for even cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| return self.km <= other | ||
| elif isinstance(other, Distance): # Якщо other — об'єкт Distance | ||
| return self.km <= other.km | ||
| return self.km <= other.km |
There was a problem hiding this comment.
The return statement here is redundant because it repeats the logic already covered in the previous conditions. Consider removing this line.
| if isinstance(other, (int, float)): # Якщо other — число | ||
| return self.km >= other | ||
| elif isinstance(other, Distance): # Якщо other — об'єкт Distance | ||
| return self.km >= other.km |
There was a problem hiding this comment.
The __ge__ method lacks a return statement for the comparison. Ensure that the method returns a boolean value for all cases.
All methods are working, added "other" type cheking