'Solution' #1636
Open
'Solution' #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 The code meets the task requirements and constraints effectively. While there's a minor issue with the __add__ method not handling unsupported types, it doesn't significantly impact the functionality. Keep up the good work, and consider adding error handling for unsupported types in the future to make your code even more robust! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
+14
to
+17
| def __add__(self, other) -> Distance: | ||
| if isinstance(other, Distance): | ||
| return Distance(self.km + other.km) | ||
| return Distance(self.km + other) |
There was a problem hiding this comment.
The __add__ method does not handle the case when other is neither a Distance instance nor a float. Consider adding a check to raise a TypeError if other is an unsupported type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.