add task solution #5028
add task solution #5028
Conversation
There was a problem hiding this comment.
Great job on implementing the calculateRentalCost function! 🎉 The code is well-structured, and you've used descriptive names and constants effectively. While there is a minor logical issue with the discount application order, it doesn't critically impact the functionality. Keep up the good work, and consider refining the logic to ensure only the highest applicable discount is applied. Keep learning and coding! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (days >= LONG_TERM_THRESHOLD) { | ||
| return totalCost - LONG_TERM_DISCOUNT; | ||
| } | ||
|
|
||
| if (days >= MID_TERM_THRESHOLD) { | ||
| return totalCost - MID_TERM_DISCOUNT; |
There was a problem hiding this comment.
There is a logical issue in the discount application. The current implementation applies the long-term discount for rentals of 7 days or more, and the mid-term discount for rentals of 3 to 6 days. However, if a rental is exactly 7 days, it should only apply the long-term discount, not both. The logic should be adjusted to ensure that only one discount is applied based on the highest applicable threshold.
No description provided.