Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #5008

Closed
wants to merge 3 commits into from
Closed

Solution #5008

wants to merge 3 commits into from

Conversation

Magdalena-Por
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution is almost there, but there are a few important improvements needed to fully meet the task requirements. 🌟 Here are the key points to address:

  1. Use of Literals in Expressions: Replace the direct use of numbers like 40, 50, and 20 with constants that have descriptive names. This will make your code more readable and maintainable.

  2. Variable Declaration: Change the declaration of totalCost from let to const since its value does not change after being assigned.

  3. Code Structure: Simplify your if else structure by using if with return. This will make your code cleaner and easier to follow.

These changes will help improve the quality and clarity of your code. Keep up the great work, and you'll have it ready in no time! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@Magdalena-Por
Copy link
Author

All issues are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants