add task solution #4994
add task solution #4994
Conversation
There was a problem hiding this comment.
Great job on implementing the calculateRentalCost function! 🎉 Your code is well-structured, with clear and descriptive variable names, and it effectively meets the task requirements. While there is a note about the sequential logic for applying discounts, it doesn't critically impact the functionality as per the task description. Keep up the good work, and consider refining the discount logic in future iterations to enhance flexibility. Keep coding! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (days >= LONG_TERM) { | ||
| return basePrice - LONG_TERM_DISCOUNT; | ||
| } | ||
|
|
||
| if (days >= SHORT_TERM) { | ||
| return basePrice - SHORT_TERM_DISCOUNT; | ||
| } |
There was a problem hiding this comment.
The logic for applying discounts is sequential, meaning if the number of days is greater than or equal to LONG_TERM, it will apply the LONG_TERM_DISCOUNT and skip checking the SHORT_TERM condition. If the intention is to apply both discounts when both conditions are met, you need to adjust the logic to accumulate discounts rather than returning immediately.
No description provided.