Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution yee #4985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

FelixTheFallen
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calculateRentalCost function! 🎉 Your code meets all the task requirements and constraints, using descriptive names and avoiding hardcoding. The logic for calculating rental costs and applying discounts is correctly implemented. Keep up the excellent work! If you want to further improve, double-check that the discount logic aligns perfectly with the task requirements. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +13 to +14
if (days >= LONG_TERM) {
return days * PRICE_PER_DAY - LONG_TERM_DISCOUNT;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the long-term discount logic is correct as per the task requirements. The current implementation applies a discount for rentals of 7 days or more.

Comment on lines +17 to +18
if (days >= SHORT_TERM) {
return days * PRICE_PER_DAY - SHORT_TERM_DISCOUNT;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the short-term discount logic is correct as per the task requirements. The current implementation applies a discount for rentals of 3 days or more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants